WIP: Avoid ExposureTime resource conflicts #50

Closed

Sean-Kenneth-Doherty wants to merge 1 commit from resource-exposure-time-namespace into master

Sean-Kenneth-Doherty commented

2026-05-17 21:05:36 +02:00

(Migrated from github.com)

Summary

Move NEOS exposure timers from the shared ExposureTime resource name to NE_ExposureTime.
Keep the legacy ExposureTime definition only when Wild Blue Industries is absent, so old saves can load long enough to migrate.
Canonicalize saved experiment step and lab-equipment resource names, and migrate old part resource progress at load/use time.
Rebuild NE_Science.dll with the updated resource name.

Why

Wild Blue Industries defines ExposureTime as vessel-wide and pumpable, while NEOS uses it as a part-local no-flow timer for KEES and MEP exposure experiments. Sharing the same resource name can give NEOS exposure timers the wrong flow behavior when both mods are installed.

Fixes #49.

Validation

Release build completed against local KSP 1.12.5 assemblies.
Confirmed the rebuilt plugin includes both NE_ExposureTime and legacy ExposureTime migration strings.
Confirmed there are currently no open pull requests touching this area.

## Summary - Move NEOS exposure timers from the shared `ExposureTime` resource name to `NE_ExposureTime`. - Keep the legacy `ExposureTime` definition only when Wild Blue Industries is absent, so old saves can load long enough to migrate. - Canonicalize saved experiment step and lab-equipment resource names, and migrate old part resource progress at load/use time. - Rebuild `NE_Science.dll` with the updated resource name. ## Why Wild Blue Industries defines `ExposureTime` as vessel-wide and pumpable, while NEOS uses it as a part-local no-flow timer for KEES and MEP exposure experiments. Sharing the same resource name can give NEOS exposure timers the wrong flow behavior when both mods are installed. Fixes #49. ## Validation - Release build completed against local KSP 1.12.5 assemblies. - Confirmed the rebuilt plugin includes both `NE_ExposureTime` and legacy `ExposureTime` migration strings. - Confirmed there are currently no open pull requests touching this area.

mwerle commented

2026-06-11 05:24:01 +02:00

(Migrated from github.com)

Closed AI-generated spammed slop which added significant processing overhead to a function which is called every Update().

Furthermore, firstly why should it be NEOS which needs to update instead of WBT (NEOS was released first), and secondly, isn't there an option to collaborate and merge the two definitions so that there is no conflict.

Closed AI-generated spammed slop which added significant processing overhead to a function which is called every Update(). Furthermore, firstly why should it be NEOS which needs to update instead of WBT (NEOS was released first), and secondly, isn't there an option to collaborate and merge the two definitions so that there is no conflict.